This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
app: fix initial preview query #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix invocation of `PREVIEW_QUERY` from `Settings.react.js` and `Preview.react.js`. This fixes the initial preview query that depend on the database name (e.g. MSSql).
|
@n-riesco Looks good. Once merged I will play with this and looks like it might help some of my stuff. Thanks for putting this together |
|
We've got confirmation in the forum that this PR fixes #356. |
|
Yep .. Looks good to me.. !! Thanks for the changes.. 💃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PREVIEW_QUERYfromSettings.react.jsandPreview.react.js. This fixes the initial preview query that dependon the database name (e.g. MSSql).
@tarzzz Would you review this PR?
cc/ @shannonlal I thought you may want to have a look at this PR, since it touches code that affects the ElasticSearch connector.